[libcxx-commits] [libcxx] eb61cf3 - [NFC][libc++][test] Enables variant test.

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 29 08:28:27 PDT 2022


Author: Mark de Wever
Date: 2022-09-29T17:28:19+02:00
New Revision: eb61cf373c7a688193456ac83c85b8554d304f28

URL: https://github.com/llvm/llvm-project/commit/eb61cf373c7a688193456ac83c85b8554d304f28
DIFF: https://github.com/llvm/llvm-project/commit/eb61cf373c7a688193456ac83c85b8554d304f28.diff

LOG: [NFC][libc++][test] Enables variant test.

Noticed this while working on D133326. Let's see whehter all compilers
now support this feature.

Reviewed By: #libc, philnik, ldionne

Differential Revision: https://reviews.llvm.org/D134818

Added: 
    

Modified: 
    libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp b/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
index f0d539c9914a8..39a7b9bd18335 100644
--- a/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
+++ b/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
@@ -253,15 +253,11 @@ int main(int, char**) {
   test_copy_ctor_valueless_by_exception();
   test_copy_ctor_sfinae();
   test_constexpr_copy_ctor();
-#if 0
-// disable this for the moment; it fails on older compilers.
-//  Need to figure out which compilers will support it.
-{ // This is the motivating example from P0739R0
-  std::variant<int, double> v1(3);
-  std::variant v2 = v1;
-  (void) v2;
-}
-#endif
+  { // This is the motivating example from P0739R0
+    std::variant<int, double> v1(3);
+    std::variant v2 = v1;
+    (void)v2;
+  }
 
   return 0;
 }


        


More information about the libcxx-commits mailing list