[libcxx-commits] [PATCH] D134829: [libc++] Include skipped headers in the --trace-includes output

Thu Sep 29 06:32:10 PDT 2022

ldionne marked an inline comment as done.
ldionne added a comment.

In D134829#3822033 <https://reviews.llvm.org/D134829#3822033>, @Mordante wrote:

> Did you look at the effect the change has on the Graphviz ouput?

I just did, and it looks just as overwhelming as it did before :-). For real though, I think it's only going to be more accurate after this patch, since we will faithfully represent the dependencies in an order-independent way. Previously, the output would be dependent of the order in which headers had their `#include`s, which made little sense.

> In D134829#3821946 <https://reviews.llvm.org/D134829#3821946>, @ldionne wrote:
>
>> @var-const Can you try applying this change locally and then re-applying your `copy` patch to see if this solves the issues you were seeing?
>
> I expect that there will still be an issue, due to the removal of `cstring` in `format` and `valarray`.

Yes, of course, but I think he knows that that part is a real issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134829/new/

https://reviews.llvm.org/D134829