[libcxx-commits] [PATCH] D134829: [libc++] Include skipped headers in the --trace-includes output

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Did you look at the effect the change has on the Graphviz ouput?

In D134829#3821946 <https://reviews.llvm.org/D134829#3821946>, @ldionne wrote:

> @var-const Can you try applying this change locally and then re-applying your `copy` patch to see if this solves the issues you were seeing?

I expect that there will still be an issue, due to the removal of `cstring` in `format` and `valarray`.

I want to have a closer look tomorrow and play with this patch myself.



================
Comment at: libcxx/test/libcxx/transitive_includes.sh.cpp:560
 // RUN: %{python} %S/transitive_includes_to_csv.py %t > %t/transitive_includes.csv
 // RUN: diff -w %S/transitive_includes/%{cxx_std}.csv %t/transitive_includes.csv
 // GENERATED-MARKER
----------------
You mention you dislike the transitive includes name, should we change it now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134829/new/

https://reviews.llvm.org/D134829