[libcxx-commits] [PATCH] D134818: [NFC][libc++][test] Enables variant test.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a project: All.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Noticed this while working on D133326 <https://reviews.llvm.org/D133326>. Let's see whehter all compilers
now support this feature.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134818

Files:
  libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp


Index: libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
===================================================================
--- libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
+++ libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
@@ -253,15 +253,11 @@
   test_copy_ctor_valueless_by_exception();
   test_copy_ctor_sfinae();
   test_constexpr_copy_ctor();
-#if 0
-// disable this for the moment; it fails on older compilers.
-//  Need to figure out which compilers will support it.
-{ // This is the motivating example from P0739R0
-  std::variant<int, double> v1(3);
-  std::variant v2 = v1;
-  (void) v2;
-}
-#endif
+  { // This is the motivating example from P0739R0
+    std::variant<int, double> v1(3);
+    std::variant v2 = v1;
+    (void)v2;
+  }
 
   return 0;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134818.463621.patch
Type: text/x-patch
Size: 856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220928/8dabfecf/attachment.bin>