[libcxx-commits] [PATCH] D134767: [libc++] Remove MSVC tests checked into the libc++ test suite

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D134767#3819279 <https://reviews.llvm.org/D134767#3819279>, @ldionne wrote:

> In D134767#3819275 <https://reviews.llvm.org/D134767#3819275>, @philnik wrote:
>
>> I'm fine with this, but we might want to look into running tests from other standard libraries on libc++ to find implementation divergence and potentially have some extra test coverage.
>
> Yes, I 100% agree. It would be great to have e.g. a CI job that runs the MSVC tests using libc++. I just don't think these tests should be checked into our own tree.

As discussed on Discord I think they need to be checked in. But We should look at that when we really start to use this feature. No objection to remove this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134767/new/

https://reviews.llvm.org/D134767