[libcxx-commits] [PATCH] D134767: [libc++] Remove MSVC tests checked into the libc++ test suite

[Louis Dionne via Phabricator via libcxx-commits]

ldionne created this revision.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

We should strive to have our own tests, except when there is overwhelming
value in using another standard library's existing tests. The reason is
that it ensures that implementations don't all start relying on the same
interpretation of the Standard.

The unique_ptr tests did not add any test coverage AFAICT, and the
forward_like tests were moved to the style used everywhere in the
libc++ test suite.

Note that I got to this because this actually broke a downstream
configuration where we use -ffreestanding. The signature of main()
was not consistent with the signature we (need to) use everywhere
in the test suite.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134767

Files:
  libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.msvc/test.compile.pass.cpp
  libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.msvc/test.cpp
  libcxx/test/std/utilities/utility/forward/forward_like.pass.cpp
  libcxx/test/std/utilities/utility/forward_like/forward_like.msvc/test.cpp
  libcxx/test/std/utilities/utility/forward_like/forward_like.msvc/test.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134767.463345.patch
Type: text/x-patch
Size: 16092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220927/4b114fef/attachment-0001.bin>