[libcxx-commits] [PATCH] D134591: [libcxx] Make stdatomic.h work when included from a C source file

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 26 06:29:43 PDT 2022


ldionne requested changes to this revision.
ldionne added a subscriber: smeenai.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for picking this up. I think you probably needed to "Commandeer" D131435 <https://reviews.llvm.org/D131435> in order to update it. But this will do, I'll ask @smeenai to close D131435 <https://reviews.llvm.org/D131435>.

Let's try to land this quickly, I realize only now that this is the source of some failures I've been seeing internally as well, so this is likely hitting a bunch of people and we should cherry-pick back to LLVM 15.



================
Comment at: libcxx/include/stdatomic.h:124
 
-#if _LIBCPP_STD_VER > 20
+#if defined(__cplusplus) && _LIBCPP_STD_VER > 20
 
----------------
Why is this change required?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134591/new/

https://reviews.llvm.org/D134591



More information about the libcxx-commits mailing list