[libcxx-commits] [PATCH] D134420: [libc++] Use intptr_t instead of ptrdiff_t for messages_base::catalog

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 23 11:40:08 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/locale:3539
     nl_catd __cat = (nl_catd)__c;
+    static_assert(sizeof(catalog) >= sizeof(nl_catd), "Unexpected nl_catd type");
     char* __n = catgets(__cat, __set, __msgid, __ndflt.c_str());
----------------
Mordante wrote:
> Is this code used in C++03? static_assert is a C++11 feature.
We have `static_assert` in C++03. We `#define static_assert(...) _Static_assert(__VA_ARGS__)` in `__config`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134420/new/

https://reviews.llvm.org/D134420



More information about the libcxx-commits mailing list