[libcxx-commits] [PATCH] D132505: [libc++] Refactor deque::iterator algorithm optimizations

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 23 08:21:02 PDT 2022


ldionne accepted this revision.
ldionne added a comment.

LGTM but let's wait for the CI to be back online for a green run and then submit.



================
Comment at: libcxx/docs/ReleaseNotes.rst:50-51
   the C library.
+- The ``ranges`` versinos of ``copy``, ``move``, ``copy_backward`` and ``move_backward`` are now also optimized for
+  ``std::deque<>::iterator``.
 
----------------



================
Comment at: libcxx/include/__algorithm/copy_backward.h:83
+
+    // When the range contains no elements __result might not be a vaid iterator
+    if (__first == __last)
----------------



================
Comment at: libcxx/include/__algorithm/move_backward.h:82
+
+    // When the range contains no elements __result might not be a vaid iterator
+    if (__first == __last)
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132505/new/

https://reviews.llvm.org/D132505



More information about the libcxx-commits mailing list