[libcxx-commits] [PATCH] D132090: [1a/3][ASan][compiler-rt] API for double ended containers

[Vitaly Buka via Phabricator via libcxx-commits]

vitalybuka added a comment.

I guess not strictly insist, but maybe cleanup descriptions a little-bit, here and other reviews.
Usually LLVM commits descriptions are high level overview of what is done, and why it's done.

E.g.

Not needed in the git commit?

> Trail of Bits developed this as part of a research project where
> we tried to find bugs using the oss-fuzz
> (using llvm-14 with our modifications) harnesses.
> Now, we want to upstream the llvm-15 port of this work.

Naming does not match, in description please keep only interface function:

> This commit adds new compiler-rt ASan sanitization API functions:
> sanitizer_annotate_de_contiguous_container_front and
> sanitizer_annotate_de_contiguous_container_back, necessary to
> sanitize/annotate double ended contiguous containers.

Not needed in the git commit, as known and unchanged?

> SHADOW_GRANULARITY is usually 8 – that value describes how
> many bytes has a block described by a single value in the
> AddressSanitizer's shadow memory and is set during llvm/clang
> compilation.

Not needed assuming we have a link to review with the "review stack"?

> Structure of our patches:
> [1a/3][ASan][compiler-rt] API for double ended containers
> [1b/3][ASan][compiler-rt] API for annotating objects memory
> [2a/3][ASan][libcxx] std::deque annotations
> [2b/3][ASan][libcxx] std::basic_string annotations
> [3/3][ASan] integration test for std::deque and std::basic_string annotations
>
>> Quoted Text




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132090/new/

https://reviews.llvm.org/D132090