[libcxx-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

[Matheus Izvekov via Phabricator via libcxx-commits]

mizvekov marked an inline comment as done.
mizvekov added inline comments.


================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:890-893
+  struct {
+    bool DoIt;
+    FunctionDecl *Existing = nullptr;
+  } Merge = {false};
----------------
ChuanqiXu wrote:
> Is this struct necessary? I feel two separate variables may be more clear.
I would have used a tuple, but a struct allows us to give names to the components.

I think it makes sense and is more clear to group these things together, but maybe it could be even clearer if there was a lambda to setup the merge instead, so I will go ahead and implement that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131858/new/

https://reviews.llvm.org/D131858