[libcxx-commits] [PATCH] D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxxabi/cmake/Modules/HandleLibCXX.cmake:4-6
+option(LIBCXXABI_USE_PREBUILT_LIBCXX_HEADERS
+    "Use prebuilt libc++ headers because we are not also building libcc++."
+    OFF)
----------------
Ericson2314 wrote:
> phosek wrote:
> > Ericson2314 wrote:
> > > My `TARGET cxx-headers` trick didn't work because that target isn't defined until afterwords, since `libcxx` mostly depends on`libcxxabi`.
> > Could we use `LIBCXXABI_LIBCXX_INCLUDE` instead of introducing another option? That is, if `LIBCXXABI_LIBCXX_INCLUDE` is not empty, it implies using prebuilt libc++ headers.
> I suppose so, should we rename it something like `LIBCXXABI_LIBCXX_INCLUDE_PREBUILT` if so?
> 
> Per the TODO deprecated `libcxxabi/test/lit.site.cfg.in` uses this variable and I am not sure why. So that gave me some trepidation about changing things more.
How about something like `LIBCXXABI_EXTERNAL_LIBCXX_INCLUDES`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132526/new/

https://reviews.llvm.org/D132526