[libcxx-commits] [PATCH] D133127: [libc++][test] Improves transitive includes.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ my suggestions. Thanks a lot for working on this simplification!



================
Comment at: libcxx/test/libcxx/transitive_includes_to_csv.py:23
+
+def parse_line(line: str) -> header:
+    match = re.match(r"(\.+) (.+)", line)
----------------
Python has a `csv` module you could use instead.


================
Comment at: libcxx/test/libcxx/transitive_includes_to_csv.py:92-93
+if __name__ == "__main__":
+    if len(sys.argv) != 2:
+        sys.exit("Specify the directory with the input files")
+
----------------
Can we get a super simple `argparse` here? It would be helpful if someone wants to call the script with `--help`.


================
Comment at: libcxx/utils/ci/run-buildbot:191
     ! grep -rn '[^ -~]' libcxx/include libcxx/src libcxx/test libcxx/benchmarks \
+           --exclude '*.csv' \
            --exclude '*.dat' \
----------------
We could use a space instead of a tab as a delimiter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133127/new/

https://reviews.llvm.org/D133127