[libcxx-commits] [PATCH] D134031: [libc++][test] Adds format string helper.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/support/test_format_string.h:10-11
+
+#ifndef SUPPORT_TEST_FORMAT_STRING_HPP
+#define SUPPORT_TEST_FORMAT_STRING_HPP
+
----------------



================
Comment at: libcxx/test/support/test_format_string.h:43-44
+
+#  error
+"Please create a vendor specific version of the test typedef and file a review at https://reviews.llvm.org/"
+
----------------
This will also avoid the comment becoming stale when/if we move to github PRs.


================
Comment at: libcxx/test/support/test_format_string.h:48
+
+#endif // SUPPORT_TEST_FORMAT_STRING_HPP
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134031/new/

https://reviews.llvm.org/D134031