[libcxx-commits] [PATCH] D133661: [libc++] Improve binary size when using __transaction

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 20 01:55:40 PDT 2022


philnik updated this revision to Diff 461509.
philnik marked 2 inline comments as done.
philnik added a comment.

- Address comments

`__transaction` is currently used exclusively for handling exception guarantees, so I decided to rename the class instead of introducing multiple classes. We can still re-add a `__transaction` class later if we have use cases for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133661/new/

https://reviews.llvm.org/D133661

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__memory/uninitialized_algorithms.h
  libcxx/include/__utility/exception_guard.h
  libcxx/include/__utility/transaction.h
  libcxx/include/module.modulemap.in
  libcxx/include/utility
  libcxx/test/libcxx/utilities/exception_guard.pass.cpp
  libcxx/test/libcxx/utilities/transaction.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133661.461509.patch
Type: text/x-patch
Size: 15774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220920/9d5ebf44/attachment.bin>


More information about the libcxx-commits mailing list