[libcxx-commits] [PATCH] D134124: [libc++] Fix wrong implementation of CityHash

Tommy Chiang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 19 19:41:36 PDT 2022


oToToT added a comment.

Besides using a new hash algorithm, would we want to upgrade our CityHash version to v1.1 [1]?
The v1.1 version claims to have a better hash quality. (I haven't test it though)
And, IIUC, upgrading to v1.1 wouldn't change the ABI.

[1] https://github.com/google/cityhash/commit/0469694b4609253742bcd3008c0b3f3ba9fcd9ba


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134124/new/

https://reviews.llvm.org/D134124



More information about the libcxx-commits mailing list