[libcxx-commits] [PATCH] D133326: [libc++] Applies P0602R4 retro-actively.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added subscribers: mstorsjo, arichardson.
Herald added a project: All.
Mordante updated this revision to Diff 461280.
Mordante added a comment.
Mordante updated this revision to Diff 461292.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Polished test whether works with all Clang versions.


Mordante added a comment.

Reenable the proper CI.


Mordante added a comment.

The patch is tested with all Clang versions in this build https://buildkite.com/llvm-project/libcxx-ci/builds/13640


While testing a test failure of C++17 with Clang ToT it was noticed the
paper

  P0602R4 variant and optional should propagate copy/move triviality

was not applied as a DR in libc++.

This was discovered while investigating the issue "caused by" D131479 <https://reviews.llvm.org/D131479>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133326

Files:
  libcxx/include/optional
  libcxx/include/variant
  libcxx/test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp
  libcxx/test/std/utilities/optional/optional.object/optional.object.assign/move.pass.cpp
  libcxx/test/std/utilities/optional/optional.object/optional.object.ctor/move.fail.cpp
  libcxx/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
  libcxx/test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp
  libcxx/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
  libcxx/test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133326.461292.patch
Type: text/x-patch
Size: 17252 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220919/c524f4af/attachment.bin>