[libcxx-commits] [PATCH] D134124: [libc++] Fix wrong implementation of CityHash

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

I'm not familiar with this code, but I find it concerning that the change causes no tests to fail.
I leave the review to somebody more familiar with this code.

In D134124#3798046 <https://reviews.llvm.org/D134124#3798046>, @oToToT wrote:

> As mentioned in PR56606, CityHash seems not being actively maintained anymore.  
> Do we want to change our hash implementation to FarmHash or other hash functions?

I had a short look at FarmHash. Judging by the bugtracker it doesn't seem to be maintained either.

> Not sure whether this is a good place for discussion, though.

#libcxx on Discord is the best place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134124/new/

https://reviews.llvm.org/D134124