[libcxx-commits] [PATCH] D134031: [libc++][test] Adds format string helper.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

In D134031#3797641 <https://reviews.llvm.org/D134031#3797641>, @vitaut wrote:

> One minor comment inline otherwise looks great. Much more readable than `template operator()`!

I agree. I will adjust the other tests in a separate commit.



================
Comment at: libcxx/test/std/time/time.syn/formatter_tests.h:33-35
+inline constexpr auto check =
+    []<class CharT, class... Args>(
+        std::basic_string_view<CharT> expected, test_format_string<CharT, Args...> fmt, Args&&... args) constexpr {
----------------
vitaut wrote:
> Why is this a lambda and not a normal function? If it was the latter you could have a locale overload without inventing a new name.
Good question. Basically since I used that pattern before. I've changed it to a normal function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134031/new/

https://reviews.llvm.org/D134031