[libcxx-commits] [PATCH] D134036: [libc++][format] Implements string escaping.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added subscribers: arichardson, mgorny.
Herald added a project: All.
Mordante updated this revision to Diff 460731.
Mordante added a comment.
Mordante updated this revision to Diff 460745.
Mordante updated this revision to Diff 460982.
Mordante updated this revision to Diff 460997.
Mordante published this revision for review.
Mordante added reviewers: ldionne, vitaut.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Fixes CI and minor improvement.


Mordante added a comment.

Fixes CI.


Mordante added a comment.

Fixes CI and some cleanups.


Mordante added a comment.

CI fixes.



================
Comment at: libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp:165
+  // as you requested before. I will update the other tests after this commit lands.
+  test_format(SV("['\\'', '\"']"), SV("[{:?}, {:?}]"), CharT('\''), CharT('"'));
+
----------------
Note example s4 is wrong in P2286, but has been corrected in the WP.
https://github.com/cplusplus/draft/pull/5751


Implements parts of

- P2286R8 Formatting Ranges

Depends on D134031 <https://reviews.llvm.org/D134031>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134036

Files:
  libcxx/docs/Status/Cxx2bPapers.csv
  libcxx/docs/Status/FormatPaper.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__format/escaped_output_table.h
  libcxx/include/__format/formatter_char.h
  libcxx/include/__format/formatter_output.h
  libcxx/include/__format/formatter_string.h
  libcxx/include/__format/parser_std_format_spec.h
  libcxx/include/__format/unicode.h
  libcxx/include/module.modulemap.in
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.c_string.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.char_array.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.const_char_array.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.formatter.spec/formatter.string.pass.cpp
  libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp
  libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp
  libcxx/test/std/utilities/format/format.functions/format_tests.h
  libcxx/test/support/test_macros.h
  libcxx/utils/CMakeLists.txt
  libcxx/utils/ci/run-buildbot
  libcxx/utils/data/unicode/DerivedCoreProperties.txt
  libcxx/utils/data/unicode/DerivedGeneralCategory.txt
  libcxx/utils/data/unicode/README.txt
  libcxx/utils/generate_escaped_output_table.py