[libcxx-commits] [PATCH] D133124: [libc++][lit][AIX] Enable test case last_write_time.pass.cpp for AIX

[Xing Xue via Phabricator via libcxx-commits]

xingxue marked 2 inline comments as done.
xingxue added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:504-505
+        {"dir, past_time", dir, past_time}
+#if !defined(_AIX)
+        ,
         {"file, before_epoch_time", file, before_epoch_time},
----------------
ldionne wrote:
> xingxue wrote:
> > ldionne wrote:
> > > Instead, can we move the comment above to here, always define `before_epoch_time` & friends, and only have one `#ifdef` block? That will reduce the scope of the workaround.
> > Defining `before_epoch_time` and friends without using them will fail the test because of `-Werror,-Wunused-variable`.
> You can use `(void)` to silence it!
Ah, I see, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133124/new/

https://reviews.llvm.org/D133124