[libcxx-commits] [PATCH] D128998: [libunwind] Handle G in personality string

[Daniel Kiss via Phabricator via libcxx-commits]

danielkiss added inline comments.


================
Comment at: libunwind/src/libunwind.cpp:186
+// This resets MTE tags of tagged frames to zero.
+extern "C" _LIBUNWIND_HIDDEN int __unw_step_untag(unw_cursor_t *cursor) {
+  _LIBUNWIND_TRACE_API("__unw_step_untag(cursor=%p)",
----------------
`__unw_step` is used in phase 1(search) and phase 2(apply).
maybe would be better to differentiate as __unw_step_search and __unw_step_apply (or similar) to make architecture agonistic.
For PAC we need to calculate the return value always but with MTE we could just untag memory when actually doing the unwinding.
same for `step(bool untag = false);` could be `step(bool search_phase = false);`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998