[libcxx-commits] [PATCH] D128998: [libunwind] Handle G in personality string

[Saleem Abdulrasool via Phabricator via libcxx-commits]

compnerd added inline comments.


================
Comment at: libunwind/src/DwarfInstructions.hpp:224
+          __asm__ __volatile__(
+              ".arch_extension memtag\nstg %[Ptr], [%[Ptr]]\n" ::[Ptr] "r"(p)
+              : "memory");
----------------
Would be nice to split this over two lines.


================
Comment at: libunwind/src/libunwind.cpp:186
+// particular, this resets MTE tags of tagged frames to zero.
+_LIBUNWIND_HIDDEN int __unw_clean_step(unw_cursor_t *cursor) {
+  _LIBUNWIND_TRACE_API("__unw_clean_step(cursor=%p)",
----------------
I think that `untag` is better than clean - `__unw_step_untag`.  We are untagging the memory and that makes it more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128998/new/

https://reviews.llvm.org/D128998