[libcxx-commits] [PATCH] D133665: [libc++][format] Granularizes the format header.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a subscriber: mgorny.
Herald added a project: All.
Mordante updated this revision to Diff 459354.
Mordante added a comment.
Mordante updated this revision to Diff 459371.
Mordante updated this revision to Diff 459379.
Mordante updated this revision to Diff 459477.
Mordante updated this revision to Diff 459794.
Mordante published this revision for review.
Mordante added a reviewer: ldionne.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Fixes CI.


Mordante added a comment.

Attempts to fix the CI.


Mordante added a comment.

Attempts to fix the CI.


Mordante added a comment.

Attempts to fix CI.


Mordante added a comment.

Attempts to fix CI based on observations while with @ldionne.



================
Comment at: libcxx/include/__format/format_functions.h:797
 
-#endif // !defined(_LIBCPP_HAS_NO_INCOMPLETE_FORMAT)
-
----------------
This removal seems to be the issue on macOS backdeployment.

I think basically `<format>` never worked on back-deployment targets. We should look into this as a separate effort -- we shouldn't be getting compilation errors if we just try to include e.g. `<chrono>` with `-fexperimental-library` on a back-deployment target, which I think is probably the case right now. I think investigating this would be trying to remove this in `run-buildbot`:

```
# TODO: Enable experimental features during back-deployment -- right now some of the availability
#       annotations are incorrect, leading to test failures that could be avoided.
PARAMS+=";enable_experimental=False"
```


Moves the last pieces of code to its own header.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133665

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__format/format_functions.h
  libcxx/include/format
  libcxx/include/module.modulemap.in
  libcxx/test/libcxx/private_headers.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133665.459794.patch
Type: text/x-patch
Size: 38904 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220915/eab008a3/attachment-0001.bin>