[libcxx-commits] [PATCH] D111283: [clang] template / auto deduction deduces common sugar

David Rector via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 13 05:41:35 PDT 2022


davrec added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:12367
+  case Type::Class:                                                            \
+    llvm_unreachable("Unexpected " Kind ": " #Class);
+
----------------
Could we just return `X` here? Would that just default to the old behavior instead of crashing whenever unforeseen cases arise?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111283/new/

https://reviews.llvm.org/D111283



More information about the libcxx-commits mailing list