[libcxx-commits] [PATCH] D133364: [libc++] Remove old CI configurations and update the supported compiler versions

Mon Sep 12 02:05:11 PDT 2022

philnik added inline comments.

================
Comment at: libcxx/docs/index.rst:107
 ============ =============== ========================== =====================
-Clang        13, 14                                     latest two stable releases per `LLVM's release page <https://releases.llvm.org>`_
+Clang        14, 15, 16                                 latest two stable releases per `LLVM's release page <https://releases.llvm.org>`_ and current trunk
 AppleClang   13                                         latest stable release per `Xcode's release page <https://developer.apple.com/documentation/xcode-release-notes>`_
----------------
Mordante wrote:
> I would prefer to only mention releases here. Having Clang 16 may lead to confusion since it's not released yet.
> For AppleClang we already have some version 14 support.
> I feel having support for the work-in-progress function can be left implicit.
I was actually always confused by the `latest two stable releases`. The released versions also only claim support for the last two versions, i.e. libc++14 claims compatibility with clang 12 and 13, but //not// 14 (see https://releases.llvm.org/14.0.0/projects/libcxx/docs/index.html), which I find //very// confusing. The new wording makes the situation clear.

================
Comment at: libcxx/utils/ci/buildkite-pipeline.yml:505
-          limit: 2
-    timeout_in_minutes: 120
-
----------------
Mordante wrote:
> I didn't remove this part, and I would prefer it in a separate commit; which can be this commit.
I'll split it if we want to reword the supported compilers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133364/new/

https://reviews.llvm.org/D133364