[libcxx-commits] [PATCH] D130695: [libc++][ranges]Refactor `copy{, _backward}` and `move{, _backward}`

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

Sorry, I know I approved it before, but I just noticed that this patch still regresses on some optimizations (in particular optimizing `reverse_iterator<contiguous-iterator>`), so maybe I'm missing more and I'm also questioning the usefulness of the changes more and more, so I'd like some clarification. What exactly is the goal of the refactoring here? How does the refactored code do the job better than forwarding `copy_backward`, `move` and `move_backward` to `copy`?  The answers to these questions would probably also be good to have in the commit message. I first thought that his patch removed some of the complication in `copy.h`, but the longer I think about it it the more it looks to me like it's just shifting the complexity around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130695/new/

https://reviews.llvm.org/D130695