[libcxx-commits] [PATCH] D133323: [libc++] Bump _LIBCPP_STD_VER to the next expected C++ version

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D133323#3782371 <https://reviews.llvm.org/D133323#3782371>, @Mordante wrote:

> In D133323#3771034 <https://reviews.llvm.org/D133323#3771034>, @philnik wrote:
>
>> In D133323#3770792 <https://reviews.llvm.org/D133323#3770792>, @Mordante wrote:
>>
>>>> We've decided to use _LIBCPP_STD_VER >= xy while discussing to change the constexpr macros, so let's finally bump the version macro to match that.
>>>
>>> I don't recall that was decided during that in that review. Can you share the link where that decision was made? (Or remove that part of the commit message.)
>>
>> I brought it up during the discussion on Discord and nobody objected, so I assumed everybody was OK with it. @avogelsgesang and @ldionne also explicitly asked about it there.
>
> I don't feel "I assumed everybody was OK with it" sounds as a discision.
> I don't mind seeing it in new code. But rather not see existing code in, areas with a lot of active development, changed. Or changes that affect patches under review.

I do remember we had a discussion on Discord and several folks chimed in, but I don't remember exactly who did. My understanding after the discussion on Discord is that we were going to move forward with this approach. My understanding is also that I was the only one to oppose at the beginning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133323/new/

https://reviews.llvm.org/D133323