[libcxx-commits] [PATCH] D133490: [libc++] Fix compilation error on platforms that don't implement std::tm

Sat Sep 10 11:41:50 PDT 2022

Mordante added a comment.

In D133490#3778087 <https://reviews.llvm.org/D133490#3778087>, @ldionne wrote:

> In D133490#3777447 <https://reviews.llvm.org/D133490#3777447>, @Mordante wrote:
>
>> Which platforms don't have `tm` that we support? Can we add a CI for them?
>
> Apple's DriverKit is an example of that. Adding CI for that is on my todo list, but there's some stuff that needs to happen before that can be done.

Thanks for the info.

LGTM!

================
Comment at: libcxx/include/__chrono/convert_to_tm.h:27
+// which must have the same properties as std::tm.
+template <class _Tm, class _ChronoCalendarTimePoint>
+_LIBCPP_HIDE_FROM_ABI _Tm __convert_to_tm(const _ChronoCalendarTimePoint& __value) {
----------------
I'm not thrilled by this name, but when I have a better name I'll incorporate that in a next patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133490/new/

https://reviews.llvm.org/D133490