[libcxx-commits] [PATCH] D114786: [libc++] Remove the ability to use the std::nullptr_t emulation in C++03 mode

Fri Sep 9 06:30:54 PDT 2022

ldionne marked an inline comment as done.
ldionne added a comment.

In D114786#3779094 <https://reviews.llvm.org/D114786#3779094>, @rprichard wrote:

> In D114786#3778965 <https://reviews.llvm.org/D114786#3778965>, @rprichard wrote:
>
>> I think I can rename its `nullptr_t` to `my_nullptr_t` to avoid the collision.
>
> The test is already unsupported for C++03, so a better fix is to just use the standard library type, either `::nullptr_t` or `std::nullptr_t`. Maybe I'll go with the latter.

Yeah, I'd recommend simply using `std::nullptr_t`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114786/new/

https://reviews.llvm.org/D114786