[libcxx-commits] [PATCH] D133535: [libc++] Suppress -Wctad-maybe-unsupported on types w/o deduction guides

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Sep 8 15:06:22 PDT 2022


ldionne created this revision.
Herald added a subscriber: arichardson.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

There are a handful of standard library types that are intended
to support CTAD but don't need any explicit deduction guides to
do so.

This patch adds a dummy deduction guide to those types to suppress
-Wctad-maybe-unsupported (which gets emitted in user code).

This is a re-application of the original patch by Eric Fiselier in
fcd549a7d828 which had been reverted due to reasons lost at this point.
I also added the macro to a few more types. Reviving this patch was
prompted by the discussion on https://llvm.org/D133425.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133535

Files:
  libcxx/include/__config
  libcxx/include/__functional/default_searcher.h
  libcxx/include/__iterator/back_insert_iterator.h
  libcxx/include/__iterator/front_insert_iterator.h
  libcxx/include/__iterator/move_iterator.h
  libcxx/include/__mutex_base
  libcxx/include/mutex
  libcxx/include/shared_mutex
  libcxx/include/string_view
  libcxx/test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/implicit_ctad.pass.cpp
  libcxx/test/std/iterators/predef.iterators/insert.iterators/front.insert.iterator/implicit_ctad.pass.cpp
  libcxx/test/std/iterators/predef.iterators/move.iterators/move.iterator/implicit_ctad.pass.cpp
  libcxx/test/std/strings/string.view/string.view.deduct/implicit.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.guard/implicit_ctad.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.scoped/implicit_ctad.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/implicit_ctad.pass.cpp
  libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.unique/implicit_ctad.pass.cpp
  libcxx/test/std/utilities/function.objects/func.search/func.search.default/implicit_ctad.pass.cpp
  libcxx/utils/libcxx/test/params.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133535.458893.patch
Type: text/x-patch
Size: 15961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220908/25e29d58/attachment-0001.bin>


More information about the libcxx-commits mailing list