[libcxx-commits] [PATCH] D128577: [libc++][chrono] Implements formatter day.
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Sep 6 08:48:28 PDT 2022
ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.
================
Comment at: libcxx/include/chrono:699
+// (In C++20 it's solved by removing transitive headers.)
+// On Windows the experimental library isn't available avoid depending the main
----------------
Is this comment still required? I think it is no longer needed since we inlined the destructor of `format_error` to workaround Windows DLL issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128577/new/
https://reviews.llvm.org/D128577
More information about the libcxx-commits
mailing list