[libcxx-commits] [PATCH] D133252: [libc++][random] Removes transitive includes.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a subscriber: ldionne.
Mordante added a comment.

In D133252#3771962 <https://reviews.llvm.org/D133252#3771962>, @EricWF wrote:

> Who is asking for these changes?
>
> It's gunna break a lot of code, so we better have a rock solid, user-provided, justification for doing it.

Thanks for your concern.

There was no request, but a set of TODOs I cleaned up.

I want to discuss this with @ldionne since this change is special and not in a positive way.
Before and after the change exactly the same set of headers is included, therefore I marked the change NFC originally.
But not including them in `random` itself breaks the modular build.

Therefore I'm not convinced we should do this, but at least the test changes are an improvement and if we don't do it we need to remove these TODOs in `random` and add a warning instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133252/new/

https://reviews.llvm.org/D133252