[libcxx-commits] [PATCH] D111283: [clang] template / auto deduction deduces common sugar
David Rector via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Sep 5 17:03:37 PDT 2022
davrec accepted this revision.
davrec added a comment.
I hope I'm not stepping on any toes given the recent changes in code ownership, but I'm accepting this and D130308 <https://reviews.llvm.org/D130308> because
1. They are a nice improvement to the AST that naturally follows from the earlier work adding sugar to type deductions,
2. I have given it a fairly close look and it LGTM,
3. @rsmith has taken a step back and so may not be available to give it a final look,
4. @mizvekov has verified that the performance impact is negligible, and
5. Other reviewers seem to have at least given it a once over and have not identified major issues.
Anyone object/need more time to review?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111283/new/
https://reviews.llvm.org/D111283
More information about the libcxx-commits
mailing list