[libcxx-commits] [PATCH] D132785: [libc++] Avoid instantiating type_trait classes

Mon Sep 5 15:37:44 PDT 2022

philnik added a comment.

In D132785#3767230 <https://reviews.llvm.org/D132785#3767230>, @ldionne wrote:

> LGTM assuming fixing the GCC issues don't require any significant changes. My preference would actually be to rewrite the SFINAE in a separate patch prior to this one, so that this one doesn't need to change at all. If you do that, ping me on Discord so I can fast track it.

It was just replacing `_IsSame<typename remove_cv<_Tp>::type, void>::value` with `is_void<_Tp>::value`, so I don't think it's worth an extra PR.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132785/new/

https://reviews.llvm.org/D132785