[libcxx-commits] [PATCH] D133323: [libc++] Bump _LIBCPP_STD_VER to the next expected C++ version

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a subscriber: avogelsgesang.
philnik added a comment.

In D133323#3770792 <https://reviews.llvm.org/D133323#3770792>, @Mordante wrote:

>> We've decided to use _LIBCPP_STD_VER >= xy while discussing to change the constexpr macros, so let's finally bump the version macro to match that.
>
> I don't recall that was decided during that in that review. Can you share the link where that decision was made? (Or remove that part of the commit message.)

I brought it up during the discussion on Discord and nobody objected, so I assumed everybody was OK with it. @avogelsgesang and @ldionne also explicitly asked about it there.



================
Comment at: libcxx/include/__config:51
+// Expected release year of the next C++ version
+#      define _LIBCPP_STD_VER 23
 #    endif
----------------
Mordante wrote:
> Please do the same for the test macro including the comment.
The test macro is defined as 99 currently, so we can already use `TEST_STD_VER >= 23`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133323/new/

https://reviews.llvm.org/D133323