[libcxx-commits] [PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

David Rector via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 5 11:41:35 PDT 2022


davrec accepted this revision.
davrec added a comment.

LGTM aside from a nit



================
Comment at: clang/include/clang/AST/DeclTemplate.h:455
 
+  bool isTypeAlias() const;
+
----------------
Add doc, e.g. "Whether this is a written or built-in type alias template."

And nit: maybe move this above the `classof` functions, since those and other boilerplate functions are usually the last public members.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133262/new/

https://reviews.llvm.org/D133262



More information about the libcxx-commits mailing list