[libcxx-commits] [PATCH] D133323: [libc++] Bump _LIBCPP_STD_VER to the next expected C++ version

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision as: Mordante.
Mordante added a comment.

> We've decided to use _LIBCPP_STD_VER >= xy while discussing to change the constexpr macros, so let's finally bump the version macro to match that.

I don't recall that was decided during that in that review. Can you share the link where that decision was made? (Or remove that part of the commit message.)

Regardless of the objection above I still think this change is nice to have. Based on the track record of the committee I feel we can expect the 3 year cycle. (Even when 26 becomes 27 it will be a simple search and replace.)

A few nits otherwise LGTM. I feel more developers should have a look so I leave the final approval to them.



================
Comment at: libcxx/include/__config:50
 #    else
-#      define _LIBCPP_STD_VER 22 // current year, or date of c++2b ratification
+// Expected release year of the next C++ version
+#      define _LIBCPP_STD_VER 23
----------------



================
Comment at: libcxx/include/__config:51
+// Expected release year of the next C++ version
+#      define _LIBCPP_STD_VER 23
 #    endif
----------------
Please do the same for the test macro including the comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133323/new/

https://reviews.llvm.org/D133323