[libcxx-commits] [PATCH] D133196: [libc++] Add test to ensure that type trait aliases in dependent return types can be mangled

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 2 12:30:03 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp:75
+template <class T>
+std::make_unsigned_t<T> make_unsigned() {
+  return {};
----------------
Mordante wrote:
> What selection criteria is used? For example I miss `std::to_underlying`.
`std::to_underlying` isn't a type trait. I guess you mean `std::underlying_type`? If you mean that, it's checked below. All `_t` type traits should be checked here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133196/new/

https://reviews.llvm.org/D133196



More information about the libcxx-commits mailing list