[libcxx-commits] [PATCH] D131898: [libc++] Implement P0591R4 (Utility functions to implement uses-allocator construction)

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision as: ldionne.
ldionne added a comment.

Leaving final approval to @huixie90



================
Comment at: libcxx/include/__memory/uses_allocator_construction.h:151
+  struct __pair_constructor {
+    using _PairMut = remove_cv_t<_Pair>;
+
----------------
philnik wrote:
> huixie90 wrote:
> > nit: what does `Mut` mean?
> mutable
I think `Mutable` would be clearer, especially given the question. I had the same.


================
Comment at: libcxx/test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_pair.pass.cpp:56
         assert((P.checkConstruct<std::piecewise_construct_t const&,
                                  std::tuple<std::allocator_arg_t, SA&>&&,
                                  std::tuple<SA&>&&
----------------
Would it be valid to pass it as a `const&` before C++20?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131898/new/

https://reviews.llvm.org/D131898