[libcxx-commits] [PATCH] D133196: [libc++] Add test to ensure that type trait aliases in dependent return types can be mangled

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp:9
+
+// Check that all the type_trait aliases can be mangled
+
----------------
Please add some more comment why we need to test this.


================
Comment at: libcxx/test/std/utilities/meta/meta.unary/dependent_return_type.compile.pass.cpp:75
+template <class T>
+std::make_unsigned_t<T> make_unsigned() {
+  return {};
----------------
What selection criteria is used? For example I miss `std::to_underlying`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133196/new/

https://reviews.llvm.org/D133196