[libcxx-commits] [PATCH] D129054: [libc++] Consolidate the different [[nodiscard]] configuration options into a single one

[Nico Weber via Phabricator via libcxx-commits]

thakis added a comment.

In D129054#3762104 <https://reviews.llvm.org/D129054#3762104>, @philnik wrote:

> @thakis I think your comments should be addressed by D128267 <https://reviews.llvm.org/D128267>.

That's cool, but there still was (is) a Window where `[[nodiscard]]` disappeared for people who define `_LIBCPP_ENABLE_NODISCARD`.

In practice, it looks like nothing regressed for us in the 1 week it took us to notice this, but if some hard-to-update dependency had added code that ignored a nodiscard, this would've been pretty painful to deal with.

So I still think it'd be nice if that `#error` was there until D128267 <https://reviews.llvm.org/D128267> lands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129054/new/

https://reviews.llvm.org/D129054