[libcxx-commits] [PATCH] D137134: [libc++][Android] XFAIL aligned_alloc and timespec_get tests

Ryan Prichard via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 31 16:10:59 PDT 2022


rprichard created this revision.
rprichard added reviewers: ldionne, danalbert.
Herald added a subscriber: danielkiss.
Herald added a project: All.
rprichard requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Mark tests XFAIL that use APIs that are unsupported on old versions of
Android:

- aligned_alloc isn't available until API 28.
- timespec_get isn't available until API 29.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D137134

Files:
  libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp
  libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp
  libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp


Index: libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/ctime.timespec.compile.pass.cpp
@@ -17,6 +17,9 @@
 // unavailable until macOS 10.15
 // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}
 
+// ::timespec_get is available starting with Android Q (API 29)
+// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27|28)}}
+
 #include <ctime>
 #include <type_traits>
 
Index: libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp
===================================================================
--- libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp
+++ libcxx/test/std/language.support/support.runtime/cstdlib.aligned_alloc.compile.pass.cpp
@@ -18,6 +18,9 @@
 // ::aligned_alloc is not implemented on Windows
 // XFAIL: target={{.+}}-windows-{{.+}}
 
+// ::aligned_alloc is available starting with Android P (API 28)
+// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27)}}
+
 #include <cstdlib>
 #include <type_traits>
 
Index: libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp
===================================================================
--- libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp
+++ libcxx/test/std/depr/depr.c.headers/stdlib_h.aligned_alloc.compile.pass.cpp
@@ -18,6 +18,9 @@
 // ::aligned_alloc is not implemented on Windows
 // XFAIL: target={{.+}}-windows-{{.+}}
 
+// ::aligned_alloc is available starting with Android P (API 28)
+// XFAIL: target={{.+}}-android{{(eabi)?(21|22|23|24|25|26|27)}}
+
 #include <stdlib.h>
 #include <type_traits>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137134.472176.patch
Type: text/x-patch
Size: 1882 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20221031/34c45c12/attachment.bin>


More information about the libcxx-commits mailing list