[libcxx-commits] [PATCH] D136667: Check return address stored in normal stack and CET shadow stack in unwind process phase2

[H.J Lu via Phabricator via libcxx-commits]

hjl.tools added a comment.

In libgcc, the same macro is used for both _Unwind_RaiseException_Phase2 and _Unwind_ForcedUnwind_Phase2. 
_Unwind_ForcedUnwind usages in glibc always terminate and don't unwind stack.   We may not need to check
return address on shadow stack in this case.



================
Comment at: libunwind/src/UnwindLevel1.c:318
   unsigned framesWalked = 1;
+#if defined(_LIBUNWIND_USE_CET)
+  unsigned long shadowStackTop = _get_ssp();
----------------
MaskRay wrote:
> `#ifdef`
> `#ifdef`




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136667/new/

https://reviews.llvm.org/D136667