[libcxx-commits] [PATCH] D135824: [libc++] Move preferred_name declarations into the forward declaring headers and add pmr preferred names

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/regex:6848
 using cmatch  = match_results<const char*>;
-using wcmatch = match_results<const wchar_t*>;
 using smatch  = match_results<std::pmr::string::const_iterator>;
----------------
EricWF wrote:
> This would have caused anybody including regex without wchar_t to fail to build, right?
> 
> How did we not catch that before?
The problem here is that we don't have a true C library that does not provide `wchar_t`. So yes, this would have failed indeed and we would have caught it when building for a platform that truly doesn't provide `wchar_t`. This is a known hole in our CI coverage, but I think we'd need a custom C library in order to catch this (or an upstream platform that does not provide `wchar_t`, which is equivalent).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135824/new/

https://reviews.llvm.org/D135824