[libcxx-commits] [PATCH] D136245: [libc++][PMR] Deprecate the implementation in std::experimental

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

LGTM w/ a suggested rewording of the release note. Thanks for adding a link to the policy in the commit message. Also, the commit message could be reworded to

  This commit deprecates <experimental/memory_resource> since we now ship the non-experimental
  version of it. Per the libc++ policy [1], we are deprecating the experimental feature in
  upcoming LLVM 16 and will remove it entirely in LLVM 18.
  
  [1]: https://libcxx.llvm.org/DesignDocs/ExperimentalFeatures.html#id4

This should minimize the amount of work that someone has to do in order to understand what's the change and the context around it.



================
Comment at: libcxx/docs/ReleaseNotes.rst:95-96
 
+- The contents of ``<experimental/memory_resource>`` are now deprecated. Use ``<memory_resource>`` instead.
+  The implementation in ``<experimental/memory_resource>`` will be removed in LLVM 18.
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136245/new/

https://reviews.llvm.org/D136245