[libcxx-commits] [PATCH] D135781: [libc++] Assume that builtins for math.h functions are available

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 30 14:12:27 PDT 2022


philnik added inline comments.


================
Comment at: libcxx/include/math.h:294
 
 #include <__config>
 
----------------
ldionne wrote:
> Mingw is failing the `clang-tidy` test, and only that. Can you please figure out what's wrong and add the missing tests?
This should be fixed in D136908.


================
Comment at: libcxx/include/math.h:432
 
-template <class _A1, class _A2>
-_LIBCPP_HIDE_FROM_ABI
-bool
-__libcpp_islessgreater(_A1 __x, _A2 __y) _NOEXCEPT
-{
-    return islessgreater(__x, __y);
+template <class _Tp, std::__enable_if_t<std::is_integral<_Tp>::value, int> = 0>
+_LIBCPP_HIDE_FROM_ABI bool isnan(_Tp) _NOEXCEPT {
----------------
EricWF wrote:
> Were'n
I guess this wasn't planned?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135781/new/

https://reviews.llvm.org/D135781



More information about the libcxx-commits mailing list