[libcxx-commits] [PATCH] D135781: [libc++] Assume that builtins for math.h functions are available

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF added a comment.

In D135781#3894426 <https://reviews.llvm.org/D135781#3894426>, @philnik wrote:

> I can't find any indication that the builtins are provided conditionally. It also doesn't really make sense, since the compiler could still emit the call, even if the hosting environment doesn't provide the function.

Good point. What about `-Xclang -fno-math-builtins`? Clang provides an option to turn the builtins off, and libc++ currently works when it's specified. We should state why we don't care about supporting this option.

But @ldionnes comments need to be addressed. And are a good example of why changes like this should be scoped to a single type of change.

But this still needs a description before it proceeds.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135781/new/

https://reviews.llvm.org/D135781