[libcxx-commits] [PATCH] D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage

[Eric Fiselier via Phabricator via libcxx-commits]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

Missing description.

All changes need a description.

In particular, why is the behavior we're adding for `int128` correct, and why do we want it?

Further, I don't think deduplicated these tests is useful. It makes the tests harder to read by virtue of introducing indirection. 
I don't think this change should proceed. I don't think it's an improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136908/new/

https://reviews.llvm.org/D136908