[libcxx-commits] [PATCH] D136908: [libc++] Remove duplication in math_h.pass.cpp and improve coverage

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp:832-834
+#ifndef TEST_HAS_CHAR8_T
+  test_integral_three_args<T, U, char8_t, PromoteResult>();
+#endif
----------------
huixie90 wrote:
> Slightly confused by the condition. I read it as "If char8_t is NOT defined, then we have the test to test the char8_t"
Oops, yes. They should be `TEST_HAS_NO_CHAR8_T`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136908/new/

https://reviews.llvm.org/D136908